add slope threshold parameter #384
Conversation
|
Dear all, Should I do something else about this pull request? Thanks. |
| @@ -3,7 +3,7 @@ | |||
| from typing import Any, Tuple | |||
| from qcodes.instrument import VisaInstrument | |||
| from qcodes.parameters import MultiParameter, Parameter, ParameterWithSetpoints | |||
| from qcodes.validators import Arrays, Ints | |||
| from qcodes.utils.validators import Arrays, Ints | |||
There was a problem hiding this comment.
This changes the import from the current official location to a deprecated legacy location. Could you change this back
| @@ -86,8 +79,8 @@ def get_raw(self) -> np.ndarray: | |||
| """ | |||
| assert isinstance(self.instrument, FCA3100) | |||
| self.instrument.write('CALCulate:AVERage:STATe 0') | |||
| self.instrument.write('ARM:COUN {}'.format(self.instrument.samples_number.get_latest())) | |||
| data_str=self.instrument.ask("READ:ARRay? {}".format(self.instrument.samples_number.get_latest())) | |||
| self._instrument.write('ARM:COUN {}'.format(self._instrument.samples_number.get_latest())) | |||
There was a problem hiding this comment.
Why this change (from instrument to _instrument)
There was a problem hiding this comment.
No reason, fixed it.
|
|
||
| def startread(self): | ||
| self.ask("Read?") | ||
| return |
There was a problem hiding this comment.
This looks partially complete? Should this return the value from ask or is it really meant to discard that and return None
There was a problem hiding this comment.
Leftover from debugging.
I removed it
|
@edumur Sorry for the delay. Has been very busy with other stuff. Left some comments inline. Would you also be able to look into why the tests are failing in CI |
Head branch was pushed to by a user without write access
|
@jenshnielsen No worries ;) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 10.49% 10.48% -0.01%
==========================================
Files 138 138
Lines 18378 18380 +2
==========================================
Hits 1928 1928
- Misses 16450 16452 +2 ☔ View full report in Codecov by Sentry. |
Dear qcodes people,
I hope to have done the git things correctly this time.
This pull request simply add two parameters to control the slope threshold.
Thanks.
Étienne.