-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SC5511B driver #141
base: main
Are you sure you want to change the base?
Add SC5511B driver #141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 18.90% 17.34% -1.57%
==========================================
Files 124 125 +1
Lines 14935 16112 +1177
==========================================
- Hits 2823 2794 -29
- Misses 12112 13318 +1206
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tank you @ttshaw1 for the contribution!
i only changed the driver to use the instrument instance's own logger (here's a bit on how to use it https://qcodes.github.io/Qcodes/examples/logging/logging_example.html#Filtering-log-messages-by-instrument ).
it would be great to make private all the methods that are actually gets/sets of the parameters, but it's ok :)
i'll make a new release of qcodes_contrib_drivers after this PR merges so that you can install this driver as part of qcodes_contrib_drivers using pip install qcodes_contrib_drivers
@ttshaw1 could you have a look at these typing errors https://github.com/QCoDeS/Qcodes_contrib_drivers/runs/7405036031?check_suite_focus=true ? if haven't worked with python typing and mypy before, we can do one of the following: exclude this driver from type checking alltogether, add |
Add first pass at driver for SC5511B
@ttshaw1 is there still interest in this driver? It would need a bit of work to get the CI to pass |
Added driver for SignalCore SC5511B. Plenty of room for optimizations and new features but might be enough to get some other group up and running.