feat: add device_features to automatically determine what is supported. #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ignore ci error - will fix when i squash |
|
Will this help with automatically exposing all the supported features and options like mopping modes for currently unsupported devices like the Saros 10? |
allenporter
requested changes
Aug 8, 2025
roborock/containers.py
Outdated
| try: | ||
| l = o % 4 | ||
| target_index = -((o // 4) + 1) | ||
| p = new_feature_info_str[target_index] |
There was a problem hiding this comment.
Can we convert the string to a number then do a bit check?
allenporter
reviewed
Aug 8, 2025
…ework device_features
|
Made some changes to match that the data actually comes from init app status Had to rework logic as there were some false assumptions. Also pulled it out of containers as to not crowd that file. |
allenporter
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long change so i am separating it from the other PR. Basically just a bunch of mathematical calculations to determine what is supported.