-
Notifications
You must be signed in to change notification settings - Fork 559
Bugfixes and testing of linear templates #3781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsiirola
wants to merge
38
commits into
Pyomo:main
Choose a base branch
from
jsiirola:linear-template-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,636
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- iterate over the underlying reference when guessing the dimen This prevents recursion when templatizing. - inconsistent dimen is reported as None
This reverts commit c7c5d6f.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3781 +/- ##
==========================================
+ Coverage 89.24% 89.34% +0.09%
==========================================
Files 907 907
Lines 104818 104866 +48
==========================================
+ Hits 93548 93690 +142
+ Misses 11270 11176 -94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This PR is primarily adding more comprehensive testing of templatizing (and compiling) linear models. As part of flusing out the tests, this resolves a number of issues / bugs in the templatizer, the linear template compiler, and in general Pyomo:
General Pyomo changes
Param.extract_valuesto returndefaultdictfor Params with default valuesInvalidConstraintErrorexception for constraints that cannot be emitted to the solversSetOfwhen iterating over IndexedComponent objects indexed by non-finite SetsSetOf.dimenshould returnUnknownSetDimen(not 0) if the underlying reference has no dataUpdates to the templatizer
attempt_importto break circular dependencies intemplate_exprUnknownSetDimenwhen iterating over template generators and treat like jagged setssum()that do not sum over generatorssum()whose generator doesn't create a template indexsum()that appear to iterate over things other than Pyomo Set objectsUpdates to the linear template compiler
check_duplicatesandremove_fixed_varsoptions (this is not more efficiently implementable through sparse matrix operations0IndexedComponent.SkipChanges proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: