-
Notifications
You must be signed in to change notification settings - Fork 546
Modified _parse_gdx_results in GAMS.py to replace _parse_special_value #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is a small thing, but we should add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the test infrastructure tests against a reasonably current GAMS on Jenkins and a very old version of GAMS on GHA, To get build feedback from GHA, I would suggest preserving compatibility withe old GAMS API.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3629 +/- ##
==========================================
- Coverage 88.93% 85.75% -3.19%
==========================================
Files 888 888
Lines 102406 102435 +29
==========================================
- Hits 91079 87844 -3235
- Misses 11327 14591 +3264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It is unfortunate that e1da345 was committed... that introduced a bunch of non-functional changes that are confusing review of this PR. For the future, we run (and test against) |
This is my bad @jsiirola. In this case, would the best practice is to make a new PR on a clean branch with the changes to the import statement? |
That is completely up to you. You can just revert that commit on this branch and it is likely to be OK. If that still leaves "a mess" then you can decide if it is easier to just recreate a new branch / PR. |
Fixes #3624
Summary/Motivation:
When parsing the results of a model after it has been solved, the level and dual value are obtained through a series of
if
statements in_parse_special_values
that may cause slowdowns. This PR added GAMS existing functions to handle data parser for these special values in_parse_gdx_results
.Changes proposed in this PR:
_parse_special_values
with GAMS special value parser in_parse_gdx_results
.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: