fix: remove misleading second arg from assertTrue/assertFalse calls#1381
Merged
bact merged 3 commits intoPyThaiNLP:devfrom Mar 31, 2026
Merged
fix: remove misleading second arg from assertTrue/assertFalse calls#1381bact merged 3 commits intoPyThaiNLP:devfrom
bact merged 3 commits intoPyThaiNLP:devfrom
Conversation
assertTrue(expr, True) passes True as the failure message parameter, not as the expected value. The tests passed accidentally because is_native_thai returns a truthy value. Remove the second argument so assertions properly test the return value.
bact
reviewed
Mar 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes misleading boolean “second arguments” from several unittest.TestCase.assertTrue/assertFalse calls in test_morpheme, where the second parameter is actually a failure message (msg), not an expected value.
Changes:
- Updated
test_is_native_thaiassertions to callassertTrue(...)/assertFalse(...)with only the condition. - Reduced confusion in tests by avoiding incorrect “expected value” style usage.
bact
requested changes
Mar 30, 2026
|
bact
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do
Fix
assertTrue(result, True)in test_morpheme — the second arg is the failure message, not the expected value