Skip to content

Fix types in tests; Run mypy check workflow on tests#1367

Merged
bact merged 4 commits intoPyThaiNLP:devfrom
bact:fix-types-test
Mar 24, 2026
Merged

Fix types in tests; Run mypy check workflow on tests#1367
bact merged 4 commits intoPyThaiNLP:devfrom
bact:fix-types-test

Conversation

@bact
Copy link
Copy Markdown
Member

@bact bact commented Mar 24, 2026

What do these changes do

Fix remaining mypy issues in tests

  • Passed code styles and structures
  • Passed code linting checks and unit test

@bact bact added this to the 5.3.3 milestone Mar 24, 2026
@bact bact added this to PyThaiNLP Mar 24, 2026
@bact bact added refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case labels Mar 24, 2026
@bact bact moved this to In progress in PyThaiNLP Mar 24, 2026
@sonarqubecloud
Copy link
Copy Markdown

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 24, 2026

Coverage Status

coverage: 66.598%. remained the same
when pulling 8b79ed0 on bact:fix-types-test
into 56567c1 on PyThaiNLP:dev.

@bact bact merged commit adc9230 into PyThaiNLP:dev Mar 24, 2026
27 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in PyThaiNLP Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants