-
Notifications
You must be signed in to change notification settings - Fork 1
[DO NOT MERGE] Imports SweatStack library for assessment #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Personally I think te best way to design the interface is to something like a composite pattern. Were The a general About the opinionated column I think it important that there is always an option to get the full data. But I’m also fan of some filter functionality to make it more user friendly for common use cases. |
I agree with you that the code should probably be structured in a composite way. However, for usability and intuitiveness, I think this library should at least also offer a If we force |
Yes even better, sounds like we are on the same page! Should we also consider functionality for writing fit files? For example workout files. |
Writing files would be a really nice feature that is not available in most libraries (also outside of Python), but I would say it's not a top priority. |
Shall we create issues for ideas like this (writing FIT files) or would that turn into an issue mess? |
The issue mess is inevitable. Nevertheless I think it's a good idea to create issues with the ideas we have! |
starting an issue (#6) for discussing the project structure further. |
Let's close this issue and potentially re-open when we start with the |
@dierickxsimon Can you review this code that I imported from SweatStack?
At the moment, it depends on fitdecode but that can (and should) be easily replaced with the Garmin FIT Python SDK.
I think we should mainly discuss if the interface and how the data is returned (including the "opiniated" column handling) is how we would like it for this new library.