Skip to content

Use doc-comment to test guide and readme #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Conversation

Alexander-N
Copy link
Member

Closes #385

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #454 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   87.66%   87.58%   -0.08%     
==========================================
  Files          63       63              
  Lines        3355     3352       -3     
==========================================
- Hits         2941     2936       -5     
- Misses        414      416       +2
Impacted Files Coverage Δ
src/lib.rs 0% <ø> (ø) ⬆️
src/err.rs 61.21% <0%> (-1.22%) ⬇️
src/type_object.rs 88.4% <0%> (-0.12%) ⬇️
src/ffi3/objimpl.rs 0% <0%> (ø) ⬆️
src/ffi3/floatobject.rs 100% <0%> (ø) ⬆️
src/ffi3/modsupport.rs 100% <0%> (ø) ⬆️
src/ffi3/pyerrors.rs 40% <0%> (ø) ⬆️
src/types/sequence.rs 94.05% <0%> (ø) ⬆️
src/types/dict.rs 93.33% <0%> (ø) ⬆️
src/ffi3/boolobject.rs 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7149a1f...faa3fed. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #454 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   87.66%   87.58%   -0.08%     
==========================================
  Files          63       63              
  Lines        3355     3352       -3     
==========================================
- Hits         2941     2936       -5     
- Misses        414      416       +2
Impacted Files Coverage Δ
src/lib.rs 0% <ø> (ø) ⬆️
src/err.rs 61.21% <0%> (-1.22%) ⬇️
src/type_object.rs 88.4% <0%> (-0.12%) ⬇️
src/ffi3/objimpl.rs 0% <0%> (ø) ⬆️
src/ffi3/floatobject.rs 100% <0%> (ø) ⬆️
src/ffi3/modsupport.rs 100% <0%> (ø) ⬆️
src/ffi3/pyerrors.rs 40% <0%> (ø) ⬆️
src/types/sequence.rs 94.05% <0%> (ø) ⬆️
src/types/dict.rs 93.33% <0%> (ø) ⬆️
src/ffi3/boolobject.rs 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7149a1f...faa3fed. Read the comment docs.

Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge this after ci passes

@konstin konstin merged commit ffb66a3 into PyO3:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactivate doctests for guide
2 participants