Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier plugin debugging by noting source filename of internal exceptions #1958

Closed
wants to merge 1 commit into from
Closed

Easier plugin debugging by noting source filename of internal exceptions #1958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/flake8/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,12 @@ def run_checks(self) -> tuple[str, Results, dict[str, int]]:
row, column = self._extract_syntax_information(e)
self.report(code, row, column, f"{type(e).__name__}: {e.args[0]}")
return self.display_name, self.results, self.statistics
except BaseException as e:
try:
e.add_note(f"while checking {self.filename}")
except AttributeError:
pass # PEP-678 .add_note() method is new in Python 3.11
raise

logical_lines = self.processor.statistics["logical lines"]
self.statistics["logical lines"] = logical_lines
Expand Down
Loading