do not trigger hardcoded password on empty string, #714 #738
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneDanini
requested review from
ericwb,
ghugo,
lukehinds and
sigmavirus24
as code owners
|
Are you not concerned about someone having a default of an empty password and not providing one? It seems as though that would be as concerning to me as a hard-coded password. In reality, it's a hard-coded empty password meaning there's no credentials there. Even so, the tests seem to fail |
|
This would add a very low confidence case to the hardcoded password rule. I'd rather not introduce this behavior. In addition, I feel using another library like detect-secrets is a better alternative than Bandit for finding secrets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.