Renamed files, directories, and replaced non-inclusive text #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made use of more inclusive terminology in place of the bias jargon. This change should have no impact on any functionality. This change is intended to simply swap out static text. Resolves 647
KOLANICH
suggested changes
Dec 5, 2020
There was a problem hiding this comment.
blocklistis not a very correct term. The things that are inblacklists are not technically blocked inbandit.- replacing
master... do you thing M. of Sc. degree should also be renamed?
Overall:
- It is the campaign of replacement of neutral terms with the words
whiteandblackracist (we in Russia have an idiom that can literaly be translated into English as "the thief has his hat burning", usually attributed to a folk story about an improvised guilty-knowledge test to detect thieves at market and meaning the situation when someone socially inacceptable (i.e. the thief from the story) trying to play innocent (in the story it'd be to just ignore the scream, rather that touching the hat) but fails because he is a bad actor), not the words being replaced. - About the word
master, it again has multiple meanings,owner of slavesis only one of them.
ericwb
requested changes
Dec 6, 2020
There was a problem hiding this comment.
This breaks backward compatibility. Users may already be using blacklist in a automated command line or custom config file. It needs to handle both new and old terminology.
Also, there is a duplicate, earlier, and competing PR: #627
|
No activity on this PR in quite a while. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made use of more inclusive terminology in place of the bias jargon.
This change has no impact on any functionality. The intention to simply swap out static text.
Resolves #647