fix: correct no-prefix no-suffix exclude for top-level dirs (#975) #1028
+17
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-kamphorst
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
b-kamphorst
force-pushed
the
975-fix-exclude-directories-in-cwd
branch
from
880fcc9 to
18d1bf8
Compare
Use guard clauses and any to reduce level of nesting.
b-kamphorst
force-pushed
the
975-fix-exclude-directories-in-cwd
branch
from
18d1bf8 to
35825e4
Compare
|
Friendly reminder to @ericwb, @lukehinds and/ or @sigmavirus24 for considering this PR. |
|
Another friendly reminder to @ericwb, @lukehinds and/ or @sigmavirus24. Your consideration of this PR would be much appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bandit 1.7.5 has some inconsistent behaviour. Assume a directory with just one subdirectory in it, which in turn contains a single file:
./tests/build.pyThe following behaviour is observed:
bandit . -vrx ./testsignores the file,bandit . -vrx testignores the file,bandit . -vrx testsdoes NOT ignore the file.This PR removes the internal tweaking of an excluded path if the path is a directory.
No breaking change is foreseen.
Closes #975