Skip to content

Refactor CI workflow for logic verification#86

Open
Pranav-MSK wants to merge 2 commits into
Py-Contributors:mainfrom
Pranav-MSK:ci/workflow-chain
Open

Refactor CI workflow for logic verification#86
Pranav-MSK wants to merge 2 commits into
Py-Contributors:mainfrom
Pranav-MSK:ci/workflow-chain

Conversation

@Pranav-MSK

Copy link
Copy Markdown
Contributor

Updated workflow to trigger on completion of 'Welcome Bot' and modified steps for repository checkout and comment posting.

Description

Updated the Logic Verification CI workflow to trigger on the completion of the Welcome Bot workflow using the workflow_run event. This ensures a deterministic execution order where the welcome message is guaranteed to appear before technical verification results, resolving the race condition in the PR timeline. I have also updated the checkout and commenting steps to pull context directly from the triggering workflow.

Closes #85


Type of Change

  • feat
  • fix
  • docs
  • refactor
  • chore
  • accidental genius

Checklist

Overengineering Verification

  • I have introduced at least one unnecessary abstraction layer
  • The solution is more complex than the problem warrants
  • A reasonable engineer would question at least one design decision
  • I have named something in a way that requires further explanation

Validation

  • pytest passes locally with no failures
  • New functionality is covered by tests
  • I have not deleted tests to make CI green
  • Documentation has been updated if needed

Traceability

  • This PR references a related issue
  • The branch name vaguely reflects the chaos introduced

General

  • Future contributors may question my decisions, but not my confidence
  • Code has been self-reviewed
  • No secrets, credentials, or hardcoded paths were smuggled in
  • I have read the CONTRIBUTING.md guidelines

Screenshots (if applicable)


Additional Notes

The shift from pull_request_target to workflow_run required explicitly mapping the PR number and head SHA from the triggering event context, as these are no longer implicitly available in the job environment.


"Any fool can write code that a computer can understand. Good programmers write code that humans can understand — but we don't do that here."

Updated workflow to trigger on completion of 'Welcome Bot' and modified steps for repository checkout and comment posting.

Signed-off-by: Pranav M S Krishnan <pranavmskrishnan@gmail.com>
@github-actions

Copy link
Copy Markdown

✅ Logic Verified!

The Automated Logic Suite has confirmed that 1 is still 1.

  • Environment: Ubuntu-latest
  • Status: Mathematical Sanity Confirmed

You are safe to merge this chaos.

Signed-off-by: Pranav M S Krishnan <pranavmskrishnan@gmail.com>
@github-actions

Copy link
Copy Markdown

✅ Logic Verified!

The Automated Logic Suite has confirmed that 1 is still 1.

  • Environment: Ubuntu-latest
  • Status: Mathematical Sanity Confirmed

You are safe to merge this chaos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): Fix race condition / comment timing between Welcome Bot and Logic Verification

1 participant