Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table-metadata): Keeps the notes on values on default selection PXWEB2-616 #357

Merged
merged 5 commits into from
Mar 24, 2025

Conversation

likp
Copy link
Contributor

@likp likp commented Mar 24, 2025

The value notes get lost after applying a ValueSet or Grouping in CNMM. This PR compensates and adds the value notes.

@likp likp changed the title fix(table-metadata): Keeps the notes on values on default selection fix(table-metadata): Keeps the notes on values on default selection PXWEB2-616 Mar 24, 2025
@likp likp marked this pull request as ready for review March 24, 2025 14:23
Copy link
Contributor

@MikaelNordberg MikaelNordberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@likp likp merged commit 3392779 into main Mar 24, 2025
11 checks passed
@likp likp deleted the fix/notes branch March 24, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants