Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pxweb2 438 sidesheet notes #559

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

Feature/pxweb2 438 sidesheet notes #559

wants to merge 57 commits into from
+879 −71

Conversation

MikaelNordberg
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 27, 2025 •
edited
Loading

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc1ceb6
Status: ✅  Deploy successful!
Preview URL: https://a99a3ceb.pxweb2.pages.dev
Branch Preview URL: https://feature-pxweb2-438-sidesheet.pxweb2.pages.dev

View logs

@MikaelNordberg
Show NoNotes if table has no notes
5c15222
@MikaelNordberg
Display mandatory notes at table level
ebd1acd
@MikaelNordberg
Prettier code
49d4998
@MikaelNordberg
Only pass PxTable metadata part to Notes tab
6d9e7e3
@MikaelNordberg
Check if table has any notes
11dbabe
@MikaelNordberg
Handle "No notes at all" and "No notes for this specific selection"
df7490b
@MikaelNordberg
Prettier code
03c5edb
@MikaelNordberg
Use noteCollection as data source
be05c2e
@MikaelNordberg
Refactoring code
8375c16
@MikaelNordberg
Handle non mandatory notes at table level
aaafd10
@MikaelNordberg
Prettier code
ba9c458
@MikaelNordberg
Notes shall have a dot if they are more than one
21a8ea4
@MikaelNordberg
Mandatory notes displayed in different alert boxes.
575777a
@MikaelNordberg
Show non mandatory notes at variable level
8db6aea
@MikaelNordberg
Get notes at value level
d4a0ef7
@MikaelNordberg
Prettier code
ca69936
@MikaelNordberg
Show mandatory notes at value level
3cb81f4
@MikaelNordberg
Show non mandatory notes at value level
eed2962
@MikaelNordberg
Fixed use of listGroup for non mandatory notes
9845419
@MikaelNordberg
Fixed use of listGroup for mandatory variable notes
9210182
@MikaelNordberg
Merge branch 'main' into feature/PXWEB2-438-sidesheet-notes
2953341
@MikaelNordberg
Unique keys for all list items
5ba66aa
@MikaelNordberg
No listgroup for mandatory table notes
1cf8dab
@MikaelNordberg
Set heading level in List
59e3272
@MikaelNordberg
Prettier code
1fb7aba
@MikaelNordberg
Possible to give BodyLong another element type than <p>. Displays Bod…
d42553c 
…yLong as <div> in Alert.
@MikaelNordberg
Merge branch 'main' into feature/PXWEB2-438-sidesheet-notes
631cd86
@MikaelNordberg
Now gets footnote from the "total metadata"
59cc0bd
@MikaelNordberg
Localized heading text for mandatory variabel
09f776e
@MikaelNordberg
Prettier code
01e3de6
@MikaelNordberg
Merge branch 'main' into feature/PXWEB2-438-sidesheet-notes
568915a
@MikaelNordberg
Possible to inject css-classes to Alert component
70780a8
@MikaelNordberg
Added styling
766b634
@MikaelNordberg
No list if we only have 1 mandatory table note
fc8d186
@MikaelNordberg
No listgroup for non mandatory table notes
27a5462
@MikaelNordberg
New component MandatoryNotes that displays all mandatory notes
691319e
@MikaelNordberg
Capitalize first letter in variable and value names
5a45fb8
@MikaelNordberg
Possible to set heading level for Alert
7b4f037
@MikaelNordberg
Value notes for the time variable shall be sorted so the last timeper…
5748570 
…iod comes first in the list
@MikaelNordberg
Unique key for the non mandatory variables
e5c0f96
@MikaelNordberg
Merge branch 'main' into feature/PXWEB2-438-sidesheet-notes
c40e9a3
@MikaelNordberg
Merge branch 'main' into feature/PXWEB2-438-sidesheet-notes
ad672b4
@MikaelNordberg
Fix for variables that has notes at both variable- and valuelevel
e3ee8fb
@MikaelNordberg
Component for symbol explanation notes
abf8c4b
@MikaelNordberg
Prettier code
9d5a65c
@MikaelNordberg
Special characters for explanation notes are added to config.js
2f89cfb
@MikaelNordberg
Layout fixes
cab83b3
@MikaelNordberg
Merge branch 'main' into feature/PXWEB2-438-sidesheet-notes
c06f8b8
@MikaelNordberg
No list if only one mandatory note on variable level
4c044e8
@MikaelNordberg
Removed comment
e1c0464
@MikaelNordberg
Look for symbol explanation notes in both metadata and data responses…
9b2a305 
…. Look for symbol characters in start of and contained in note. Dictionary for SymbolExplanation notes to only have one note per symbol.
@MikaelNordberg
Prettier code
309a556
@MikaelNordberg
Fix to remove unnecessary space between lists
ee59b87
@MikaelNordberg
Fix for listing symbol explanation notes
fc1ceb6
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likp likp

@KentMossback KentMossback

@runejo runejo

@PerIngeVaaje PerIngeVaaje

@oyessb oyessb

@SjurSutterudSagen SjurSutterudSagen

@michaelpande michaelpande

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MikaelNordberg