PR 226 added editable descriptions#232
Open
4xdk wants to merge 10 commits intoPursuanceProject:developfrom
Open
PR 226 added editable descriptions#2324xdk wants to merge 10 commits intoPursuanceProject:developfrom
4xdk wants to merge 10 commits intoPursuanceProject:developfrom
Conversation
Updating to newest.
This reverts commit b1f4dc7.
elimisteve
reviewed
Jul 31, 2018
| class Wysiwyg extends Component { | ||
| componentWillMount() { | ||
| const {tasks: { taskMap }, taskGid, attributeName} = this.props, | ||
| attributeValue = taskMap[taskGid][attributeName], |
Contributor
There was a problem hiding this comment.
@4xdk Got a more description variable name than attributeValue?
Collaborator
Author
There was a problem hiding this comment.
Well, this variable can hold any attribute value - depending on props passed to Wysiwyg element. I think generic variable name fits in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per: #214
Supports saving to markdown and also writing markdown.
It's not perfect by any means, but I think it's a good starting point.
The one issue that I can't seem to figure out is how to make ReactMarkdown element process links and add this target="_blank" to external links.