I 134 ui should go nuts when a user completes a task#231
Open
4xdk wants to merge 5 commits intoPursuanceProject:developfrom
Open
I 134 ui should go nuts when a user completes a task#2314xdk wants to merge 5 commits intoPursuanceProject:developfrom
4xdk wants to merge 5 commits intoPursuanceProject:developfrom
Conversation
added 2 commits
July 21, 2018 22:59
elimisteve
reviewed
Jul 28, 2018
| this.setState({ | ||
| 'triggerToast': false | ||
| }); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Assumed so... Turns out not :)
elimisteve
reviewed
Jul 28, 2018
| const { status } = this.props; | ||
| return ( | ||
| <div className={"task-status-ctn task-status-" + status + " hide-small"}> | ||
| <Confetti active={ this.state.triggerToast } config={ config }/> |
elimisteve
reviewed
Jul 28, 2018
| 'WorkingOn': true, | ||
| } | ||
|
|
||
| const config = { |
Contributor
There was a problem hiding this comment.
@4xdk How about calling this confettiConfig instead?
Collaborator
Author
|
The only slight issue is that when sidebar is open, BOTH TaskStatus elements show confetti. This is actually not visible (unless you hack the dom/css with dev tools to move the sidebar), just FYI. |
Contributor
|
@4xdk Are you saying that half the confetti is thrown behind the right panel, so to speak? |
Collaborator
Author
|
@elimisteve Yeah. There's double the amount to begin with, so end visual effect is the same. There could be some additional wizardry we could do to prevent showing on both (like checking if sidebar is open maybe ?) Just not sure if it's worth it, since we can't really see the problem. |
Contributor
|
Yeah let's not worry about it right now, but good point; I'll keep this in
mind 👍 .
…On Sun, Jul 29, 2018 at 11:28 PM, 4xdk ***@***.***> wrote:
@elimisteve <https://github.com/elimisteve> Yeah. There's double the
amount to begin with, so end visual effect is the same.
There could be some additional wizardry we could do to prevent showing on
both (like checking if sidebar is open maybe ?) Just not sure if it's worth
it, since we can't really see the problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#231 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIhU9Gg6Nr_UiMiKvV02bTlx5sJCITNks5uLqeegaJpZM4Vk9XD>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Totally not sure if this is the right way (local component state) but seems to me like dispatching actions for this would overcomplicate things(?).