-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item dropping #464
Closed
Closed
Item dropping #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes multiple changes across several files to enhance functionality and improve code consistency. The most important changes include adding new dependencies, extending functionality for various structs, and modifying method implementations to use more appropriate types.
Dependency Additions:
itertools
dependency inCargo.toml
files to support new functionality.Struct Enhancements:
offset
method toBoundingBox
struct inpumpkin-core/src/math/boundingbox.rs
to allow shifting the bounding box by a given vector.Default
trait forVector2
andVector3
structs inpumpkin-core/src/math/vector2.rs
andpumpkin-core/src/math/vector3.rs
respectively, to provide default values.Vector3
struct for calculating horizontal length and implementing theSum
trait.gravity
method toEntityType
enum inpumpkin-entity/src/entity_type.rs
to return gravity values for different entity types.Method Modifications:
Click
struct methods inpumpkin-inventory/src/container_click.rs
to handle different slot action types usingu8
instead ofSlotActionType
.hotbar_mut
andmain_inventory_mut
methods toPlayerInventory
struct inpumpkin-inventory/src/player.rs
for easier access to mutable inventory slots.Protocol Updates:
CPickupItem
struct inpumpkin-protocol/src/client/play/c_pickup_item.rs
for handling item pickup events.CSetEntityMetadata
andMetadata
structs inpumpkin-protocol/src/client/play/c_entity_metadata.rs
to requireSerialize
trait.Command Execution Adjustments:
pumpkin/src/command/commands
to useArc<Server>
instead ofServer
for better concurrency handling.Testing
No.
Please follow our Coding Guidelines