runtime,runtime/pprof: clean up goroutine leak profile collection #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinderek
force-pushed
the
master
branch
30 times, most recently
from
5bf50a0 to
643f80a
Compare
Prior to Go 1.24, os.OpenFile used to support O_TRUNC on named pipes and terminal devices, even when the truncation was really ignored. This behavior was consistent with Unix semantics. CL 618836 changed the implementation of os.OpenFile on Windows and unintentionally started returning an error when O_TRUNC was used on such files. Fixes golang#76071 Change-Id: Id10d3d8120ae9aa0548ef05423a172ff4e502ff9 Reviewed-on: https://go-review.googlesource.com/c/go/+/716420 Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Alex Brainman <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Michael Pratt <[email protected]>
austinderek
force-pushed
the
master
branch
8 times, most recently
from
9f3a108 to
c37e118
Compare
austinderek
force-pushed
the
master
branch
2 times, most recently
from
9f3a108 to
c37e118
Compare
austinderek
force-pushed
the
dev.fix-goroutineleak-profile
branch
from
ddfb0aa to
233dd50
Compare
austinderek
force-pushed
the
master
branch
10 times, most recently
from
9f3a108 to
c37e118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up goroutine leak profile extraction, by removing the acquisition of goroutineProfile semaphore, and inlining the call to saveg when recording stacks; former use of doRecordGoroutineProfile had side-effects over goroutineProfile fields.
Added regression tests for goroutine leak profiling frontend.
Added stress tests for concurrent goroutine and goroutine leak profile requests.
🔄 This is a mirror of upstream PR golang#76045