chore: updates code formatting configs #126
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,15 @@ | ||
| # Editor configuration, see http://editorconfig.org | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| insert_final_newline = true | ||
| end_of_line = lf | ||
| indent_style = tab | ||
| indent_size = 2 | ||
| max_line_length = 80 | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.md] | ||
| max_line_length = off | ||
| trim_trailing_whitespace = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,24 @@ | ||
| # compiled output | ||
| tmp | ||
| api-cache | ||
|
|
||
| # dependencies | ||
| node_modules | ||
|
|
||
| # auto-gen PHP files/logs | ||
| php_errors.log | ||
|
|
||
|
|
||
| # IDE - VSCode | ||
| .vscode/* | ||
| !.vscode/settings.json | ||
| !.vscode/launch.json | ||
| !.vscode/extensions.json | ||
|
|
||
| # System Files | ||
| .DS_Store | ||
|
|
||
| # misc | ||
| npm-debug.log | ||
| yarn-error.log | ||
| package-lock.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,20 @@ | ||
| { | ||
| "phpVersion": "8.1", | ||
| "plugins": ["@prettier/plugin-php"], | ||
| "bracketSameLine": false, | ||
| "bracketSpacing": true, | ||
| "printWidth": 80, | ||
| "singleQuote": false, | ||
| "semi": true, | ||
| "trailingComma": "es5", | ||
| "tabWidth": 2, | ||
| "useTabs": true, | ||
| "overrides": [ | ||
| { | ||
| "files": ["*.js"], | ||
| "options": { | ||
| "singleQuote": true | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "recommendations": [ | ||
| "dbaeumer.vscode-eslint", | ||
| "esbenp.prettier-vscode", | ||
| "firsttris.vscode-jest-runner", | ||
| "stylelint.vscode-stylelint", | ||
|
There was a problem hiding this comment. I believe that stylelint is a completely separate package/dependency that we aren't using in this repo. Is this still an extension that we should be recommending? |
||
| "eamodio.gitlens", | ||
| "wix.vscode-import-cost", | ||
| "christian-kohler.path-intellisense", | ||
| "formulahendry.auto-rename-tag", | ||
| "deque-systems.vscode-axe-linter" | ||
| ] | ||
| } | ||
mahesh0618 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Jest Current File", | ||
| "skipFiles": ["<node_internals>/**"], | ||
| "program": "${workspaceFolder}/node_modules/.bin/jest", | ||
| "cwd": "${workspaceFolder}", | ||
| "args": [ | ||
| "test", | ||
| "--testPathPattern=${FileBasenameNoExtension}", | ||
| "--runInBand" | ||
| ], | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "neverOpen" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| { | ||
| "eslint.validate": ["json"], | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
|
Comment on lines
+3
to
+4
There was a problem hiding this comment. What happens when a developer tries to save a file and they don't have the prettier extension installed? |
||
| "editor.formatOnSave": true | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the package-lock.json is created using an indentation of 2 spaces by default. Do we want to add the package-lock.json file to .prettierignore file so that it doesn't override the default formatting?