Skip to content

Conversation

@meddle0x53
Copy link
Contributor

Motivation

Implements #2981 and also stores the timing reports as CSVs so they can be analysed.

Test Plan

The CI passes and the timings of the different tests could be viewed.

Documentation

The PR updates the CI configuration and modifies how tests are ran.

Backwards compatibility

Backwards compatible.

@vicsn
Copy link
Collaborator

vicsn commented Oct 31, 2025

Had a chat with Lukasz, nightly does have a higher chance of inadvertently breaking things, could you use cargo nextest instead? That also has an option to report timings, but it may be a bit more work to update the circleci config.

Just for context: the reason we use limited test-threads is to prevent going out of memory.

@vicsn
Copy link
Collaborator

vicsn commented Nov 4, 2025

Looks great! Can you make a PR in snarkOS as well?

@meddle0x53
Copy link
Contributor Author

@vicsn I tried a few things here (though am mostly trying to make the snarkos version work in the moment) and it seems nextest runs are slower.

So, because we are going to try to speed up things anyway either I can try to make synthesizer-workflow faster in this PR or in a next one - your decision.

@meddle0x53
Copy link
Contributor Author

meddle0x53 commented Nov 4, 2025

Actually looking around many workflows are passing for the same time, especially in the SnarkOS version. It is specific for the synthesizer-workflow and for some of the others a bit, but not so much, hmmm.

@meddle0x53 meddle0x53 force-pushed the staging branch 2 times, most recently from 8309a34 to 50c40d5 Compare November 5, 2025 11:13
Copy link
Collaborator

@vicsn vicsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@vicsn
Copy link
Collaborator

vicsn commented Nov 6, 2025

We will surely hit some edge-cases the following days on new PRs, but happy that we have this data to start optimizing

@vicsn vicsn merged commit ce07a2c into ProvableHQ:staging Nov 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants