-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Implement reporting unit test timings in CI #2995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Had a chat with Lukasz, nightly does have a higher chance of inadvertently breaking things, could you use Just for context: the reason we use limited test-threads is to prevent going out of memory. |
|
Looks great! Can you make a PR in snarkOS as well? |
|
@vicsn I tried a few things here (though am mostly trying to make the snarkos version work in the moment) and it seems nextest runs are slower. So, because we are going to try to speed up things anyway either I can try to make |
|
Actually looking around many workflows are passing for the same time, especially in the SnarkOS version. It is specific for the synthesizer-workflow and for some of the others a bit, but not so much, hmmm. |
8309a34 to
50c40d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
|
We will surely hit some edge-cases the following days on new PRs, but happy that we have this data to start optimizing |
Motivation
Implements #2981 and also stores the timing reports as CSVs so they can be analysed.
Test Plan
The CI passes and the timings of the different tests could be viewed.
Documentation
The PR updates the CI configuration and modifies how tests are ran.
Backwards compatibility
Backwards compatible.