avoid tx root derivation #2942
Open
avoid tx root derivation #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
requested changes
Oct 2, 2025
| /// Reads the deployment from a buffer. | ||
| fn read_le<R: Read>(mut reader: R) -> IoResult<Self> { | ||
| // Read the id variant. | ||
| let id_variant = u8::read_le(&mut reader)?; |
There was a problem hiding this comment.
Can this be made backwards compatible?
| let mut deployment = | ||
| serializer.serialize_struct("Deployment", len + self.id.get().is_some() as usize)?; | ||
| if let Some(id) = self.id.get() { | ||
| deployment.serialize_field("id", id)?; |
| mod string; | ||
|
|
||
| use crate::{Transaction, Transition}; | ||
| use std::sync::OnceLock; |
There was a problem hiding this comment.
please move down to line 26 so external dependencies are in the same place
| #[derive(Clone)] | ||
| pub struct Deployment<N: Network> { | ||
| /// The deployment id | ||
| id: OnceLock<DeploymentID<N>>, |
There was a problem hiding this comment.
Would a design be possible where this is just an Option<...> like we did for the previous similar caching specified in the issue?
There was a problem hiding this comment.
That would require mutable constructs to deployment all over the code base as when we call to_deployment_id it's probably best to cache the id if not computed yet once, this also implies a redundant recursive chain of callers that will have to take an &mut. We could probably do a RefCell though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #2706
Tx root derivation takes some time during block generation, but these can be cached when computed for the first time.
Test Plan
No critical or logic changes. CI should catch any regressions