Skip to content

[Fix] Set console caller and signer when executing closures. #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

[Fix] Set console caller and signer when executing closures. #2936

wants to merge 1 commit into from

Conversation

@vicsn
Copy link
Collaborator

@vicsn vicsn commented Sep 25, 2025 •
edited
Loading

Motivation

Revival of: #2525

I don't believe this exposed a soundness issue in the VM, just a lack of functionality.

Test Plan

Added a new test

  • Fix the test. Currently it fails with: "thread '' panicked at synthesizer/tests/test_vm_execute_and_finalize.rs:158:9: assertion failed: aborted_transaction_ids.is_empty()"

@vicsn vicsn requested a review from Antonio95 September 25, 2025 12:52
@vicsn vicsn added the q4 label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antonio95 Antonio95 Awaiting requested review from Antonio95

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

q4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicsn @d0cd