-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Allow external structs. #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikebenfield
wants to merge
36
commits into
staging
Choose a base branch
from
struct-namespace
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,792
−379
Open
Allow external structs. #2798
Changes from 21 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
558625f
Allow external structs.
mikebenfield 46bf2c1
Merge branch 'staging' into struct-namespace
mikebenfield e3601da
Disallow deployments using external struct before ConsensusVersion::V10.
mikebenfield 839f17d
Added more varied uses of external structs in parsing test.
mikebenfield 4112865
Merge branch 'staging' into struct-namespace
mikebenfield 0085736
Fix external_struct_fail test
mikebenfield d7e0691
Merge branch 'staging' into struct-namespace
mikebenfield 04b2a49
Fix tests
mikebenfield 593ea83
Merge branch 'staging' into struct-namespace
mikebenfield 2c1ca39
Gate external structs by < V10 rather than <= V9
mikebenfield ad6c262
Correct doc comments to say external structs
mikebenfield bb0b0f9
Respond to review comments.
mikebenfield 3d9c3a3
Fix some comments in response to review
mikebenfield 9c604cc
next_element_type in equal_or_structs
mikebenfield c854945
Add some tests
d0cd d4f0842
Add regression
d0cd 3b5fb89
Check types for structural equivalence.
mikebenfield 832e38a
Merge branch 'staging' into struct-namespace
mikebenfield 0f4bb1b
Address review comments.
mikebenfield 71aef7f
Test accessing a field of an external struct
mikebenfield e5f7e3b
clippy
mikebenfield 377e066
Disallow nonexistent structs in mappings
mikebenfield 95364fc
Merge branch 'staging' into struct-namespace
mikebenfield ee0e0ee
Merge branch 'staging' into struct-namespace
mikebenfield c015c7d
Move type checks for mapping types to check_transaction
mikebenfield 505aecc
Merge branch 'staging' into struct-namespace
mikebenfield 7e02f20
Fix mapping type check
mikebenfield 2985f4e
comments
mikebenfield 55038dc
test_v11.rs
mikebenfield 1204947
Review comments.
mikebenfield 4348c3f
Merge branch 'staging' into struct-namespace
mikebenfield b5826a2
Fix external_struct_in_mapping test
mikebenfield 96ee3a0
Merge branch 'staging' into struct-namespace
mikebenfield fd0779c
Merge branch 'staging' into struct-namespace
7a16a80
Fix a few things
985a954
Support serialize/deserialize and `size_in_bits` for external structs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.