[WIP] Track errors #3874
Draft
[WIP] Track errors #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaimast
force-pushed
the
feat/track-error
branch
from
66fd77e to
d333743
Compare
kaimast
force-pushed
the
feat/track-error
branch
2 times, most recently
from
a0b4591 to
2814ede
Compare
kaimast
force-pushed
the
feat/track-error
branch
2 times, most recently
from
6a80176 to
a22014c
Compare
kaimast
force-pushed
the
feat/track-error
branch
2 times, most recently
from
07113ce to
9d7b851
Compare
refactor(utils): move signal handling to dedicated snarkos-utilities crate
kaimast
force-pushed
the
feat/track-error
branch
from
9d7b851 to
00d0570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller version of the error handling improvements in #3842 without any of the channel rework.
This branch uses snarkVM's track-error branch (see snarkVM PR #2927) to improve error handling and logging.
Additionally, the branch contains improvements to how nodes shut down. Instead of spawning detached tasks for signal handling, the CLI now blocks in the main task until a signal is received.
That ensures panics actually end up in the main task, and also performs a clean shutdown instead of simply calling
std::process::exit.