Allow unlimited variable captures in async blocks #28910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the title says, but: Currently, we have a limit that only 16 variables can be held in async blocks. So, this patch repairs it by creating "synthetic" structs when an async block captures more than 16 variables, and also creates replacement mappings for bundled variable accesses to refer to the struct directly in the aleo bytecode.
Contributor
Author
|
Maybe a bit of an overkill with testcases and I can remove redundant ones, but those ones test tuples, operations, mix with user structs, nested structs and arrays, multiple functions and overall stress test with a lot of captures so we can see how many bundles it broke into. |
tetektoza
force-pushed
the
fix/28744_let_async_have_unlimited_captures
branch
from
65a2097 to
3a53d85
Compare
Collaborator
No such thing as "overkill with testcases"... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, but:
Currently, we have a limit that only 16 variables can be held in async blocks.
So, this patch repairs it by creating "synthetic" structs when an async block captures more than 16 variables, and also creates replacement mappings for bundled variable accesses to refer to the struct directly in the aleo bytecode.
Resolves: #28744