Add risk to dd #32
Add risk to dd #32
Conversation
| "type": "static", | ||
| "units": "$/kWh" | ||
| }, | ||
| "costing.model": { |
There was a problem hiding this comment.
@adrianaghiozzi if you want to add the model name, we should try to conform to what IMAS generally does for all of its IDSs. I'll add some logic to generate_dd to copy the .code tree under the IDSs that we have added. This should allow you to use costing.code.name.
There was a problem hiding this comment.
@orso82 Thanks, that would be great - this is just needed for the risk actor because the costs are grouped differently depending on whether it's ARIES or Sheffield (costing each coil system separately vs. all together) so the model determines how many fields are needed in dd.risk.engineering.loss
There was a problem hiding this comment.
Uhm... I have not taken a look at the code, but it sounds like you are hardcoding the number of fields based on the model, which is definitely not a robust thing to do. Perhaps it would be best to just pick a model (say ARIES), and use the TF costs from that model for the evaluation of risk.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 42.87% 42.94% +0.07%
==========================================
Files 14 14
Lines 30797 30926 +129
==========================================
+ Hits 13203 13280 +77
- Misses 17594 17646 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.