Improve @with_pool Macro Source Location for Better Coverage & Debugging

[mgyoo86]

Summary

This PR improves @with_pool and @maybe_with_pool macros by integrating __source__ and LineNumberNode handling to provide:

• Correct Codecov mapping - Function signatures now map to user source files
• Accurate stack traces - Error locations point to user code, not macros.jl
• Better debugging - Breakpoints and profiler show meaningful locations

Problem

Before This PR

julia> @with_pool pool function my_func(n)
           error("oops")
       end

julia> my_func(10)
ERROR: oops
Stacktrace:
 [1] error
 [2] macro expansion @ macros.jl:631    ← Wrong file!
 [3] my_func @ macros.jl:630            ← Wrong line!

Issues:

• Stack traces point to macros.jl instead of user's source file
• Coverage tools can't map generated code to user source
• Debugging shows macro internals rather than user code

After This PR

julia> @with_pool pool function my_func(n)
           error("oops")
       end

julia> my_func(10)
ERROR: oops
Stacktrace:
 [1] error
 [2] macro expansion @ myfile.jl:7      ← Correct!
 [3] my_func @ myfile.jl:5              ← Correct!

Verification

Quick Test

using AdaptiveArrayPools

# Define a function
@with_pool pool function test_error(n)
    x = acquire!(pool, Float64, n)
    error("test")  # Line 4 of this snippet
end

# Check stack trace
try
    test_error(10)
catch e
    display(stacktrace(catch_backtrace()))
end
# Should show your file:line, not macros.jl:XXX

[codecov]

Codecov Report

❌ Patch coverage is 79.68750% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.41%. Comparing base (e6f7791) to head (0353b3d).
⚠️ Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
src/macros.jl	79.68%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   97.08%   96.41%   -0.68%     
==========================================
  Files           8        8              
  Lines         961     1004      +43     
==========================================
+ Hits          933      968      +35     
- Misses         28       36       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR enhances the @with_pool and @maybe_with_pool macros by implementing proper source location tracking through __source__ and LineNumberNode manipulation. This ensures that stack traces, coverage reports, and debugging tools point to user code rather than internal macro implementation files.

Key Changes:

• Added __source__ parameter propagation through all macro entry points
• Implemented helper functions to manage LineNumberNode placement in generated AST
• Added comprehensive test suite to verify source location preservation across different macro usage patterns

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/macros.jl	Added source location helper functions (_find_first_lnn_index, _ensure_body_has_toplevel_lnn, _fix_try_body_lnn!) and integrated source parameter into all macro definitions and code generation functions
test/test_macro_expansion.jl	Added 388 lines of tests including helper functions for AST inspection and comprehensive test cases covering block forms, function forms, backend variants, stack trace verification, and nested/edge cases

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.