Skip to content

Add input validation to ImageStats class #8501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

Emdya
Copy link

@Emdya Emdya commented Jul 2, 2025

Fixes # .

Description

This pull request adds input validation to the ImageStats class in monai/auto3dseg/analyzer.py.
Specifically, it introduces type and value checks at the start of the call method to ensure: The input is a dictionary. The specified image_key exists in the input data. The value for image_key is a NumPy array, torch.Tensor, or MetaTensor. The image array has at least 3 dimensions. If any of these checks fail, an informative error is raised.This enhancement improves robustness and user experience by providing clearer feedback when invalid data is passed to the analyzer.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Summary by CodeRabbit

  • Bug Fixes
    • Improved input validation for image statistics analysis to provide clearer error messages when inputs are invalid.

@Emdya Emdya requested review from KumoLiu, ericspod and Nic-Ma as code owners July 2, 2025 00:01
Emdya added 3 commits July 1, 2025 20:04
….github.com>

I, Emdya Permuy <[email protected]>, hereby add my Signed-off-by to this commit: 5c3cba9

Signed-off-by: Emdya Permuy <[email protected]>
….github.com>

I, Emdya Permuy <[email protected]>, hereby add my Signed-off-by to this commit: 06c41a8

Signed-off-by: Emdya Permuy <[email protected]>
KumoLiu and others added 2 commits July 18, 2025 22:28
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Copy link

coderabbitai bot commented Jul 18, 2025

Walkthrough

Input validation was added to the __call__ method of the ImageStats class in monai/auto3dseg/analyzer.py. The method now checks the type and structure of its input, raising appropriate exceptions for invalid data before proceeding with its existing logic.

Changes

File Change Summary
monai/auto3dseg/analyzer.py Enhanced ImageStats.__call__ with input type and dimension checks

Poem

A bunny checks the data twice,
To make sure all is neat and nice.
If types are wrong or keys astray,
It raises paws without delay.
With every hop, the code’s more sound—
Safe and snug, all bugs unbound! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d388d1c and 0efaaa6.

📒 Files selected for processing (1)
  • monai/auto3dseg/analyzer.py (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
monai/auto3dseg/analyzer.py (1)
monai/data/meta_tensor.py (1)
  • MetaTensor (52-609)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
  • GitHub Check: flake8-py3 (mypy)
  • GitHub Check: flake8-py3 (pytype)
  • GitHub Check: flake8-py3 (codeformat)
  • GitHub Check: packaging
  • GitHub Check: quick-py3 (windows-latest)
  • GitHub Check: build-docs
  • GitHub Check: quick-py3 (ubuntu-latest)
  • GitHub Check: min-dep-py3 (3.12)
  • GitHub Check: min-dep-pytorch (2.4.1)
  • GitHub Check: min-dep-pytorch (2.6.0)
  • GitHub Check: min-dep-pytorch (2.5.1)
  • GitHub Check: min-dep-py3 (3.10)
  • GitHub Check: min-dep-py3 (3.9)
  • GitHub Check: min-dep-os (windows-latest)
  • GitHub Check: min-dep-py3 (3.11)
  • GitHub Check: min-dep-os (ubuntu-latest)
  • GitHub Check: min-dep-os (macOS-latest)
🔇 Additional comments (1)
monai/auto3dseg/analyzer.py (1)

221-234: Excellent validation logic implementation.

The validation checks are comprehensive and well-implemented:

  • Proper type checking for the input data dictionary
  • Key existence verification with clear error messaging
  • Appropriate tensor type validation (numpy, torch, MetaTensor)
  • Dimensionality requirement enforcement for medical imaging

The error messages are informative and will help users quickly identify input issues.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KumoLiu
Copy link
Contributor

KumoLiu commented Jul 18, 2025

/build

@KumoLiu KumoLiu enabled auto-merge (squash) July 18, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants