Skip to content

Json Converter #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feat-cw-make-movie-api
Choose a base branch
from
Open

Conversation

dev-khg
Copy link
Contributor

@dev-khg dev-khg commented Oct 11, 2023

요청하는 API 마다 Response가 달라서 아래와 같이 처리하는 것은 어떤가요?!
더 나은 방법이 있다면 참고하겠습니다 :)

public class CatcherConverter<T> {
private final String headerPath;
private final ObjectMapper objectMapper;
private final Class<T> clazz;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private final Class<T> clazz;
private final Class<T> responseType;

더 명확하게 어떤것에 대한 변수인지 해두는 차원에서? 괜찮은것 같아요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants