fix: restore prior body overflow when ProfileQrModal unmounts - #3502
Conversation
Hardcoding "" on cleanup clobbers any inline overflow that was set before the modal opened.
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
🤖 CodeAnt AI — Review Status
|
|
Exactly the follow-up I asked for, and you did the part that makes it real: the test now sets Verified against current The Merged. Thanks for splitting it out cleanly. |
6e22da7
into
Priyanshu-byte-coder:main
|
🎉 Merged! Thanks for contributing to DevTrack. If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers. Keep an eye on open issues for your next contribution! |
User description
Summary
ProfileQrModalcurrently restoresdocument.body.style.overflowto""on unmount, which clobbers any inline overflow that was set before the modal opened.RepoAnalyticsSheet.Test plan
pnpm exec vitest run test/components/ProfileQrModal.test.tsxCodeAnt-AI Description
Restore the page’s previous scroll setting after closing the profile QR modal
What Changed
Impact
✅ Preserved background scroll behavior with stacked overlays✅ Fewer unexpected page scroll changes after closing the modal💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.