Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check the type of dbt result when converting to markdown #16869

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: support runs that output a FreshnessResult
dominictarro committed Jan 28, 2025
commit b8a900e914e04e74edf998bf98321fc150dbcb15
5 changes: 4 additions & 1 deletion src/integrations/prefect-dbt/prefect_dbt/cli/commands.py
Original file line number Diff line number Diff line change
@@ -5,6 +5,7 @@
from typing import Any, Dict, List, Optional, Union

import yaml
from dbt.artifacts.schemas.freshness.v3.freshness import FreshnessResult
from dbt.artifacts.schemas.run.v5.run import RunResult, RunResultOutput
from dbt.cli.main import dbtRunner, dbtRunnerResult
from dbt.contracts.results import ExecutionResult, NodeStatus
@@ -867,10 +868,12 @@ def create_summary_markdown(run_results: dict, command: str) -> str:
if run_results["Success"] != []:
successful_runs_str = ""
for r in run_results["Success"]:
if isinstance(r, RunResult):
if isinstance(r, (RunResult, FreshnessResult)):
successful_runs_str += f"* {r.node.name}\n"
elif isinstance(r, RunResultOutput):
successful_runs_str += f"* {r.unique_id}\n"
else:
successful_runs_str += f"* {r}\n"
markdown += f"""\n## Successful Nodes ✅\n\n{successful_runs_str}\n\n"""

return markdown