[UI v2] feat: Consolidates components for automation(s) routes #16804
+205
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinvillarosa
force-pushed
the
start-automations-list
branch
2 times, most recently
from
98932c2 to
f0c3eb2
Compare
devinvillarosa
requested review from
aaazzam,
cicdw,
desertaxle and
zzstoatzz
as code owners
desertaxle
requested changes
Jan 22, 2025
Comment on lines
147
to
186
| const NavHeader = ({ displayType, data }: NavHeaderProps) => { | ||
| if (displayType === "page") { | ||
| return ( | ||
| <div className="flex items-center gap-2"> | ||
| <Breadcrumb> | ||
| <BreadcrumbList> | ||
| <BreadcrumbItem> | ||
| <BreadcrumbLink | ||
| to="/automations" | ||
| className="text-xl font-semibold" | ||
| > | ||
| Automations | ||
| </BreadcrumbLink> | ||
| </BreadcrumbItem> | ||
| <BreadcrumbSeparator /> | ||
| <BreadcrumbItem className="text-xl font-semibold"> | ||
| <BreadcrumbPage>{data.name}</BreadcrumbPage> | ||
| </BreadcrumbItem> | ||
| </BreadcrumbList> | ||
| </Breadcrumb> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <Breadcrumb> | ||
| <BreadcrumbList> | ||
| <BreadcrumbItem className="text-xl"> | ||
| <BreadcrumbLink | ||
| to="/automations/automation/$id" | ||
| params={{ id: data.id }} | ||
| className="text-lg" | ||
| > | ||
| {data.name} | ||
| </BreadcrumbLink> | ||
| </BreadcrumbItem> | ||
| </BreadcrumbList> | ||
| </Breadcrumb> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
I think if a single prop controls rendering two mutually exclusive component hierarchies, that's a sign that this should be two separate components.
There was a problem hiding this comment.
Sounds good. Maybe I can just re-arrange some components.
I think the tricky part was having the different Breadcrumb headers for the 2 views
There was a problem hiding this comment.
ok, ended up just building the pages but using re-usable components
ui-v2/src/components/automations/automation-details/automation-details.tsx
Outdated
Show resolved
Hide resolved
devinvillarosa
force-pushed
the
start-automations-list
branch
from
f0c3eb2 to
3ec4cc3
Compare
devinvillarosa
force-pushed
the
start-automations-list
branch
2 times, most recently
from
e5b52a3 to
ab57414
Compare
devinvillarosa
force-pushed
the
start-automations-list
branch
from
ab57414 to
caed5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutomationDetailscomponent to serve for both/automationsand/automations/automationroutes.Next step is joining data between actions and its resources (currently randomly generated and mocked)
https://github.com/user-attachments/assets/4bc2eff1-dad7-441f-ada2-84d20cafa634
Screen.Recording.2025-01-21.at.2.12.12.PM.mov
Checklist
<link to issue>"mint.json.Relates to #15512