Add additional websocket debug logging #16801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakekaplan
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
CodSpeed Performance ReportMerging #16801 will not alter performanceComparing Summary
|
cicdw
reviewed
Jan 21, 2025
| @@ -349,15 +349,21 @@ async def __aexit__( | |||
| return await super().__aexit__(exc_type, exc_val, exc_tb) | |||
|
|
|||
| async def _reconnect(self) -> None: | |||
| logger.debug("Reconnecting websocket connection.") | |||
There was a problem hiding this comment.
any upside to using some reference ID in the logs, e.g., id(self)? Not requesting you make any changes, just tossing it out in case it's useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to identify some potentially odd behavior around how events are sent via websocket. These debug logs will help give us a better understanding of how the websocket client is working, how often it reconnects and what it spends the most time on.