Skip to content

Conversation

superMDguy
Copy link

No description provided.

@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 20:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where task arguments were not being passed to individual tasks when running multiple independent tasks concurrently. The change ensures that thread, raise_on_failure, and handlers parameters are properly propagated to each task's run_async method.

  • Updated asyncio.gather call to include task execution parameters
  • Improved code formatting by splitting the complex gather expression across multiple lines

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +46 to +48
task.run_async(
thread=thread, raise_on_failure=raise_on_failure, handlers=handlers
)
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task.run_async() method signature appears to be different from the one being called. Based on the context excerpt, task.run_async() doesn't accept thread, raise_on_failure, or handlers parameters, but this code is trying to pass them.

Suggested change
task.run_async(
thread=thread, raise_on_failure=raise_on_failure, handlers=handlers
)
task.run_async()

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant