Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debian package build workflow #96

Merged
merged 8 commits into from
Jul 26, 2024
Merged

Add debian package build workflow #96

merged 8 commits into from
Jul 26, 2024

Conversation

pugaizai
Copy link
Contributor

No description provided.

@pugaizai pugaizai mentioned this pull request Jul 26, 2024
@pugaizai pugaizai marked this pull request as draft July 26, 2024 14:30
@pugaizai pugaizai marked this pull request as ready for review July 26, 2024 14:32
@Predidit
Copy link
Owner

在合并这个PR之前,我想确认一下。

我对Linux的打包完全没有经验,我想知道使用 .deb 格式进行分发除了解决图标问题之外,可以解决 libwebkit2gtk-4.1-0 libayatana-appindicator3-1 的依赖问题吗。

@pugaizai
Copy link
Contributor Author

pugaizai commented Jul 26, 2024

我再看看
加了些依赖,现在应该好了?

@Predidit
Copy link
Owner

这个项目现在不依赖 mpv ,移除对应依赖可能可以减少构建大小?

@pugaizai
Copy link
Contributor Author

pugaizai commented Jul 26, 2024

我看构建的时候你安装了mpv-dev我就写上了,实际上也不会减少构建大小,因为这是用户那边安装的时候会依赖上mpv

@Predidit
Copy link
Owner

啊,那个有些过时,更换视频播放组件后就不依赖了。

@pugaizai
Copy link
Contributor Author

现在看看行不行?我其实不是很懂github action

@Predidit
Copy link
Owner

PR已经合并,感谢您的工作。

@Predidit Predidit merged commit 45627b0 into Predidit:main Jul 26, 2024
@pugaizai
Copy link
Contributor Author

pugaizai commented Jul 26, 2024

@Predidit pr.yaml那里我偷懒直接复制过去忘了改tag name那部分了,可能需要你修改一下

@Predidit
Copy link
Owner

这样的话,打包时的 version 字段填写 canary 合法吗。

我对打包缺乏经验的,您方便的话能否再PR一次呢。

@pugaizai
Copy link
Contributor Author

pugaizai commented Jul 26, 2024

这样的话,打包时的 version 字段填写 canary 合法吗。

我对打包缺乏经验的,您方便的话能否再PR一次呢。

参考
仅填字母的话应该是不行的,如果只是测试用的话随便一个数字都行吧

@pugaizai
Copy link
Contributor Author

这样的话,打包时的 version 字段填写 canary 合法吗。

我对打包缺乏经验的,您方便的话能否再PR一次呢。

发了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants