Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: pip tap logic and appearance #694

Merged
merged 2 commits into from
Feb 5, 2025
Merged

mod: pip tap logic and appearance #694

merged 2 commits into from
Feb 5, 2025

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Feb 5, 2025

  • 画中画模式时禁用双击全屏和快捷键全屏
  • 画中画模式时底部时间指示器右侧没有 padding
  • 修改了 videoPageController 的注释,PIP 模式 一开始我没看懂是什么

另外为什么画中画模式禁止修改窗口大小?有时候觉得太大或者太小会想要修改一下大小

@Predidit
Copy link
Owner

Predidit commented Feb 5, 2025

禁止修改窗体大小是我参考的应用的行为,那是一个第三方站点的闭源应用

也许我们可以考虑允许调整窗体大小

@Predidit
Copy link
Owner

Predidit commented Feb 5, 2025

如果你觉得可调整大小才是正确行为的话,可以在这个 PR 中加上。

@ErBWs
Copy link
Contributor Author

ErBWs commented Feb 5, 2025

加上了

@Predidit Predidit merged commit 4037672 into Predidit:main Feb 5, 2025
6 checks passed
@ErBWs ErBWs deleted the mod-pip branch February 5, 2025 14:11
ErBWs added a commit to ErBWs/Kazumi that referenced this pull request Feb 6, 2025
* mod pip

* make pip resizable

(cherry picked from commit 4037672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants