fix #590 (Volume persistence) #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你的工作，但是这个PR可能带来问题
|
|
关于移动平台这方面我再看看 |
|
测试过该版本在安卓与windows上都能正常工作 |
|
L135 可以在 volume 为 -1 时返回 100 这里使用 playerVolume 这个 getter 的目的是什么 |
|
确实，虽然这个getter返回的也是100，可以直接填入100，能减少消耗 我下午回去再修改PR |
|
感谢你的工作 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
仅在当前播放器进程中记忆音量