Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search #580

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix search #580

merged 1 commit into from
Jan 10, 2025

Conversation

xxfttkx
Copy link
Contributor

@xxfttkx xxfttkx commented Jan 10, 2025

#579 相关,

仍有问题:
image
image
点击搜索栏右边的×后,
image
image

即通过searchKeyword进入info变成了通过bangumi.name。这是正常的表现吗,看了一下,之前的代码应该也有这种问题。

@Predidit
Copy link
Owner

感谢你的PR

关于此 PR 提到的其他问题,在有关键词时使用关键词,没有时使用 bangumi.name

这里不符合预期的地方在于?

@xxfttkx
Copy link
Contributor Author

xxfttkx commented Jan 10, 2025

同样显示着搜索栏,进入card的逻辑却是不同的,感觉很奇怪吧。

多个逻辑进行番剧索引自然是好事,但这样没有任何提示我只感到不解。

@Predidit
Copy link
Owner

我们确实需要考虑一下这里的做法。

在此之前,我们先合并这个PR。

@Predidit Predidit merged commit 3706689 into Predidit:main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants