Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: bangumi item: add timestamp data #447

Closed
wants to merge 1 commit into from

Conversation

bggRGjQaUbCoE
Copy link
Contributor

Signed-off-by: bggRGjQaUbCoE <githubaccount56556@proton.me>
@Predidit
Copy link
Owner

Predidit commented Dec 7, 2024

我个人不是很喜欢这个变动,它修改了在多个地方被使用的 bangumiItem 结构体,且添加的 timestamp 不应该是 bangumiItem 的属性。

我之前考虑的方法是完全修改 favorites 这个 hive Box,将其从 List 变为 Map<int, BangumiItem> 。但这样兼容性完全无法解决。一定要兼容的话可能考虑建立新 Box 进行迁移。

@Predidit
Copy link
Owner

Predidit commented Dec 7, 2024

也许迁移应该提上日程,建立新的 BangumiFavoriteItem 似乎是可以的。因为已有的 Issue 里还有追番分类的需求。BangumiFavoriteItem 中有 BangumiItem type timestamp 三个属性。

你有兴趣完成吗,没有的话我来尝试完成。

@bggRGjQaUbCoE
Copy link
Contributor Author

OK,你来吧,我不确定数据结构需要怎么改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants