clang-tidy: remove void

Found with modernize-redundant-void-arg Signed-off-by: Rosen Penev <[email protected]>
PowerDNS · Jan 9, 2024 · df8248c · df8248c
1 parent 15c143f
commit df8248c
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/modules/godbcbackend/sodbc.cc b/modules/godbcbackend/sodbc.cc
@@ -439,7 +439,7 @@ SODBC::SODBC(
 }
 
 // Destructor.
-SODBC::~SODBC(void)
+SODBC::~SODBC()
 {
   // Disconnect from database and free all used resources.
   // SQLFreeHandle( SQL_HANDLE_STMT, m_statement );

diff --git a/modules/godbcbackend/sodbc.hh b/modules/godbcbackend/sodbc.hh
@@ -55,7 +55,7 @@ public:
     const std::string& password);
 
   //! Destructor.
-  virtual ~SODBC(void);
+  virtual ~SODBC();
 
   //! Sets the logging state.
   void setLog(bool state) override;

diff --git a/pdns/dnsrecords.hh b/pdns/dnsrecords.hh
@@ -700,7 +700,7 @@ private:
 class NSECRecordContent : public DNSRecordContent
 {
 public:
-  static void report(void);
+  static void report();
   NSECRecordContent() = default;
   NSECRecordContent(const string& content, const DNSName& zone=DNSName());
 
@@ -737,7 +737,7 @@ private:
 class NSEC3RecordContent : public DNSRecordContent
 {
 public:
-  static void report(void);
+  static void report();
   NSEC3RecordContent() = default;
   NSEC3RecordContent(const string& content, const DNSName& zone=DNSName());
 
@@ -783,7 +783,7 @@ private:
 class CSYNCRecordContent : public DNSRecordContent
 {
 public:
-  static void report(void);
+  static void report();
   CSYNCRecordContent() = default;
   CSYNCRecordContent(const string& content, const DNSName& zone=DNSName());
 
@@ -811,7 +811,7 @@ private:
 class NSEC3PARAMRecordContent : public DNSRecordContent
 {
 public:
-  static void report(void);
+  static void report();
   NSEC3PARAMRecordContent() = default;
   NSEC3PARAMRecordContent(const string& content, const DNSName& zone=DNSName());
 
@@ -835,7 +835,7 @@ public:
 class LOCRecordContent : public DNSRecordContent
 {
 public:
-  static void report(void);
+  static void report();
   LOCRecordContent() = default;
   LOCRecordContent(const string& content, const string& zone="");
 
@@ -899,7 +899,7 @@ class EUI48RecordContent : public DNSRecordContent
 {
 public:
   EUI48RecordContent() = default;
-  static void report(void);
+  static void report();
   static std::shared_ptr<DNSRecordContent> make(const DNSRecord &dr, PacketReader& pr);
   static std::shared_ptr<DNSRecordContent> make(const string& zone); // FIXME400: DNSName& zone?
   string getZoneRepresentation(bool noDot=false) const override;
@@ -914,7 +914,7 @@ class EUI64RecordContent : public DNSRecordContent
 {
 public:
   EUI64RecordContent() = default;
-  static void report(void);
+  static void report();
   static std::shared_ptr<DNSRecordContent> make(const DNSRecord &dr, PacketReader& pr);
   static std::shared_ptr<DNSRecordContent> make(const string& zone); // FIXME400: DNSName& zone?
   string getZoneRepresentation(bool noDot=false) const override;

diff --git a/pdns/tcpreceiver.hh b/pdns/tcpreceiver.hh
@@ -55,7 +55,7 @@ private:
   static bool canDoAXFR(std::unique_ptr<DNSPacket>& q, bool isAXFR, std::unique_ptr<PacketHandler>& packetHandler);
   static void doConnection(int fd);
   static void decrementClientCount(const ComboAddress& remote);
-  void thread(void);
+  void thread();
   static LockGuarded<std::map<ComboAddress,size_t,ComboAddress::addressOnlyLessThan>> s_clientsCount;
   static LockGuarded<std::unique_ptr<PacketHandler>> s_P;
   static std::unique_ptr<Semaphore> d_connectionroom_sem;

diff --git a/pdns/utility.hh b/pdns/utility.hh
@@ -68,16 +68,16 @@ public:
   Semaphore( unsigned int value = 0 );
 
   //! Destructor.
-  ~Semaphore( void );
+  ~Semaphore();
 
   //! Posts to a semaphore.
-  int post( void );
+  int post();
 
   //! Waits for a semaphore.
-  int wait( void );
+  int wait();
 
   //! Tries to wait for a semaphore.
-  int tryWait( void );
+  int tryWait();
 
   //! Retrieves the semaphore value.
   int getValue( Semaphore::sem_value_t *sval );
@@ -104,7 +104,7 @@ public:
     int timeout_usec);
 
   //! Returns the process id of the current process.
-  static pid_t getpid( void );
+  static pid_t getpid();
 
   //! Gets the current time.
   static int gettimeofday( struct timeval *tv, void *tz = NULL );