Skip to content

Commit

Permalink
sdig: add rudimentary EDE output
Browse files Browse the repository at this point in the history
  • Loading branch information
Habbie committed Sep 22, 2023
1 parent 251d8a1 commit 92e3654
Show file tree
Hide file tree
Showing 6 changed files with 140 additions and 131 deletions.
1 change: 1 addition & 0 deletions pdns/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,7 @@ sdig_SOURCES = \
dnsrecords.cc \
dnswriter.cc dnswriter.hh \
dolog.hh \
ednsextendederror.cc ednsextendederror.hh \
ednssubnet.cc iputils.cc \
libssl.cc libssl.hh \
logger.cc \
Expand Down
65 changes: 65 additions & 0 deletions pdns/ednsextendederror.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
* This file is part of PowerDNS or dnsdist.
* Copyright -- PowerDNS.COM B.V. and its contributors
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of version 2 of the GNU General Public License as
* published by the Free Software Foundation.
*
* In addition, for the avoidance of any doubt, permission is granted to
* link this program with OpenSSL and to (re)distribute the binaries
* produced as the result of such linking.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <limits>

#include "ednsextendederror.hh"

static bool getEDNSExtendedErrorOptFromStringView(const std::string_view& option, EDNSExtendedError& eee)
{
if (option.size() < sizeof(uint16_t)) {
return false;
}
eee.infoCode = static_cast<uint8_t>(option.at(0)) * 256 + static_cast<uint8_t>(option.at(1));

if (option.size() > sizeof(uint16_t)) {
eee.extraText = std::string(&option.at(sizeof(uint16_t)), option.size() - sizeof(uint16_t));
}

return true;
}

bool getEDNSExtendedErrorOptFromString(const string& option, EDNSExtendedError& eee)
{
return getEDNSExtendedErrorOptFromStringView(std::string_view(option), eee);
}

bool getEDNSExtendedErrorOptFromString(const char* option, unsigned int len, EDNSExtendedError& eee)
{
return getEDNSExtendedErrorOptFromStringView(std::string_view(option, len), eee);
}

string makeEDNSExtendedErrorOptString(const EDNSExtendedError& eee)
{
if (eee.extraText.size() > static_cast<size_t>(std::numeric_limits<uint16_t>::max() - 2)) {
throw std::runtime_error("Trying to create an EDNS Extended Error option with an extra text of size " + std::to_string(eee.extraText.size()));
}

string ret;
ret.reserve(sizeof(uint16_t) + eee.extraText.size());
ret.resize(sizeof(uint16_t));

ret[0] = static_cast<char>(static_cast<uint16_t>(eee.infoCode) / 256);
ret[1] = static_cast<char>(static_cast<uint16_t>(eee.infoCode) % 256);
ret.append(eee.extraText);

return ret;
}
66 changes: 66 additions & 0 deletions pdns/ednsextendederror.hh
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
/*
* This file is part of PowerDNS or dnsdist.
* Copyright -- PowerDNS.COM B.V. and its contributors
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of version 2 of the GNU General Public License as
* published by the Free Software Foundation.
*
* In addition, for the avoidance of any doubt, permission is granted to
* link this program with OpenSSL and to (re)distribute the binaries
* produced as the result of such linking.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#pragma once
#include "namespaces.hh"

struct EDNSExtendedError
{
enum class code : uint16_t
{
Other = 0,
UnsupportedDNSKEYAlgorithm = 1,
UnsupportedDSDigestType = 2,
StaleAnswer = 3,
ForgedAnswer = 4,
DNSSECIndeterminate = 5,
DNSSECBogus = 6,
SignatureExpired = 7,
SignatureNotYetValid = 8,
DNSKEYMissing = 9,
RRSIGsMissing = 10,
NoZoneKeyBitSet = 11,
NSECMissing = 12,
CachedError = 13,
NotReady = 14,
Blocked = 15,
Censored = 16,
Filtered = 17,
Prohibited = 18,
StaleNXDOMAINAnswer = 19,
NotAuthoritative = 20,
NotSupported = 21,
NoReachableAuthority = 22,
NetworkError = 23,
InvalidData = 24,
SignatureExpiredBeforeValid = 25,
TooEarly = 26,
UnsupportedNSEC3IterationsValue = 27,
UnableToConformToPolicy = 28,
Synthesized = 29,
};
uint16_t infoCode;
std::string extraText;
};

bool getEDNSExtendedErrorOptFromString(const char* option, unsigned int len, EDNSExtendedError& eee);
bool getEDNSExtendedErrorOptFromString(const string& option, EDNSExtendedError& eee);
string makeEDNSExtendedErrorOptString(const EDNSExtendedError& eee);
65 changes: 0 additions & 65 deletions pdns/recursordist/ednsextendederror.cc

This file was deleted.

1 change: 1 addition & 0 deletions pdns/recursordist/ednsextendederror.cc
66 changes: 0 additions & 66 deletions pdns/recursordist/ednsextendederror.hh

This file was deleted.

1 change: 1 addition & 0 deletions pdns/recursordist/ednsextendederror.hh
6 changes: 6 additions & 0 deletions pdns/sdig.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "dnswriter.hh"
#include "ednsoptions.hh"
#include "ednssubnet.hh"
#include "ednsextendederror.hh"
#include "misc.hh"
#include "proxy-protocol.hh"
#include "sstuff.hh"
Expand Down Expand Up @@ -185,6 +186,11 @@ static void printReply(const string& reply, bool showflags, bool hidesoadetails,
}
} else if (iter->first == EDNSOptionCode::PADDING) {
cerr << "EDNS Padding size: " << (iter->second.size()) << endl;
} else if (iter->first == EDNSOptionCode::EXTENDEDERROR) {
EDNSExtendedError eee;
if (getEDNSExtendedErrorOptFromString(iter->second, eee)) {
cerr << "EDNS Extended Error response: " << eee.infoCode << "/" << eee.extraText << endl;
}
} else {
cerr << "Have unknown option " << (int)iter->first << endl;
}
Expand Down

0 comments on commit 92e3654

Please sign in to comment.