Buch of Coverity "Variable copied when it could be moved" cases

PowerDNS · Feb 14, 2025 · 9132094 · 9132094
1 parent 7031f59
commit 9132094
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/pdns/arguments.cc b/pdns/arguments.cc
@@ -588,7 +588,7 @@ void ArgvMap::gatherIncludes(const std::string& directory, const std::string& su
         string msg = fullName + " is not a regular file";
         SLOG(g_log << Logger::Error << msg << std::endl,
              d_log->info(Logr::Error, "Unable to open non-regular file", "name", Logging::Loggable(fullName)));
-        throw ArgException(msg);
+        throw ArgException(std::move(msg));
       }
       vec.emplace_back(fullName);
     }
@@ -600,7 +600,7 @@ void ArgvMap::gatherIncludes(const std::string& directory, const std::string& su
     string msg = directory + " is not accessible: " + stringerror(err);
     SLOG(g_log << Logger::Error << msg << std::endl,
          d_log->error(Logr::Error, err, "Directory is not accessible", "name", Logging::Loggable(directory)));
-    throw ArgException(msg);
+    throw ArgException(std::move(msg));
   }
 
   std::sort(vec.begin(), vec.end(), CIStringComparePOSIX());

diff --git a/pdns/lua-base4.cc b/pdns/lua-base4.cc
@@ -52,7 +52,7 @@ void BaseLua4::includePath(const std::string& directory) {
       if (stat(fullName.c_str(), &statInfo) != 0 || !S_ISREG(statInfo.st_mode)) {
         string msg = fullName + " is not a regular file";
         g_log << Logger::Error << msg << std::endl;
-        throw PDNSException(msg);
+        throw PDNSException(std::move(msg));
       }
       vec.emplace_back(fullName);
     }
@@ -63,7 +63,7 @@ void BaseLua4::includePath(const std::string& directory) {
     int err = errno;
     string msg = directory + " is not accessible: " + stringerror(err);
     g_log << Logger::Error << msg << std::endl;
-    throw PDNSException(msg);
+    throw PDNSException(std::move(msg));
   }
 
   std::sort(vec.begin(), vec.end(), CIStringComparePOSIX());

diff --git a/pdns/recursordist/syncres.cc b/pdns/recursordist/syncres.cc
@@ -1000,7 +1000,7 @@ int SyncRes::AuthDomain::getRecords(const DNSName& qname, const QType qtype, std
       // we hit a delegation point!
       DNSRecord dnsRecord = *ziter;
       dnsRecord.d_place = DNSResourceRecord::AUTHORITY;
-      records.push_back(dnsRecord);
+      records.push_back(std::move(dnsRecord));
     }
   }
 

diff --git a/pdns/zonemd.cc b/pdns/zonemd.cc
@@ -17,11 +17,11 @@ void pdns::ZoneMD::readRecords(ZoneParserTNG& zpt)
     }
     catch (const PDNSException& pe) {
       std::string err = "Bad record content in record for '" + dnsResourceRecord.qname.toStringNoDot() + "'|" + dnsResourceRecord.qtype.toString() + ": " + pe.reason;
-      throw PDNSException(err);
+      throw PDNSException(std::move(err));
     }
     catch (const std::exception& e) {
       std::string err = "Bad record content in record for '" + dnsResourceRecord.qname.toStringNoDot() + "|" + dnsResourceRecord.qtype.toString() + "': " + e.what();
-      throw PDNSException(err);
+      throw PDNSException(std::move(err));
     }
     DNSRecord rec;
     rec.d_name = dnsResourceRecord.qname;