Catch exceptions by-ref

PowerDNS · Apr 30, 2018 · 819861f · 819861f
1 parent a87916d
commit 819861f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
@@ -43,12 +43,12 @@ GSQLBackend::GSQLBackend(const string &mode, const string &suffix)
   setArgPrefix(mode+suffix);
   d_db=0;
   d_logprefix="["+mode+"Backend"+suffix+"] ";
-	
+
   try
   {
     d_dnssecQueries = mustDo("dnssec");
   }
-  catch (ArgException e)
+  catch (const ArgException&)
   {
     d_dnssecQueries = false;
   }

diff --git a/pdns/dnspcap.cc b/pdns/dnspcap.cc
@@ -142,7 +142,7 @@ try
     }
   }
 }
-catch(EofException) {
+catch(const EofException&) {
   return false;
 }
 

diff --git a/pdns/ws-auth.cc b/pdns/ws-auth.cc
@@ -574,7 +574,7 @@ static void updateDomainSettingsFromDocument(UeberBackend& B, const DomainInfo&
     bool api_rectify = boolFromJson(document, "api_rectify");
     di.backend->setDomainMetadataOne(zonename, "API-RECTIFY", api_rectify ? "1" : "0");
   }
-  catch (JsonException) {}
+  catch (const JsonException&) {}
 
   if (document["account"].is_string()) {
     di.backend->setAccount(zonename, document["account"].string_value());
@@ -588,7 +588,7 @@ static void updateDomainSettingsFromDocument(UeberBackend& B, const DomainInfo&
     dnssecDocVal = boolFromJson(document, "dnssec");
     dnssecInJSON = true;
   }
-  catch (JsonException) {}
+  catch (const JsonException&) {}
 
   bool isDNSSECZone = dk.isSecuredZone(zonename);
 
@@ -757,7 +757,7 @@ static void apiZoneMetadata(HttpRequest* req, HttpResponse *resp) {
 
     try {
       kind = stringFromJson(document, "kind");
-    } catch (JsonException) {
+    } catch (const JsonException&) {
       throw ApiException("kind is not specified or not a string");
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -142,7 +142,7 @@ try @@
         }
       }
     }
-    catch(EofException) {
+    catch(const EofException&) {
       return false;
     }
@@ Expand Down @@