dnsdist: Fix automatic computation of the number of TCP workers

The previous method didn't account for TCP workers for backends.
PowerDNS · Jan 16, 2025 · 373554e · 373554e
1 parent 8ccbe63
commit 373554e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/pdns/dnsdistdist/dnsdist-configuration.hh b/pdns/dnsdistdist/dnsdist-configuration.hh
@@ -78,7 +78,7 @@ struct ImmutableConfiguration
   uint64_t d_outgoingTCPCleanupInterval{60};
   uint64_t d_outgoingDoHMaxIdlePerBackend{10};
   uint64_t d_outgoingTCPMaxIdlePerBackend{10};
-  uint64_t d_maxTCPClientThreads{0};
+  uint64_t d_maxTCPClientThreads{10};
   size_t d_maxTCPConnectionsPerClient{0};
   size_t d_udpVectorSize{1};
   size_t d_ringsCapacity{10000};

diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
@@ -3383,12 +3383,6 @@ int main(int argc, char** argv)
       }
     }
 
-    if (dnsdist::configuration::getImmutableConfiguration().d_maxTCPClientThreads == 0 && tcpBindsCount > 0) {
-      dnsdist::configuration::updateImmutableConfiguration([](dnsdist::configuration::ImmutableConfiguration& config) {
-        config.d_maxTCPClientThreads = static_cast<size_t>(10);
-      });
-    }
-
     dnsdist::configuration::setImmutableConfigurationDone();
 
     {