clang-tidy: use make functions

Found with modernize-make-* Signed-off-by: Rosen Penev <[email protected]>
PowerDNS · Jan 9, 2024 · 2a104e8 · 2a104e8
1 parent abb11ca
commit 2a104e8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/modules/bindbackend/binddnssec.cc b/modules/bindbackend/binddnssec.cc
@@ -146,7 +146,7 @@ void Bind2Backend::setupDNSSEC()
   if (getArg("dnssec-db").empty() || d_hybrid)
     return;
   try {
-    d_dnssecdb = shared_ptr<SSQLite3>(new SSQLite3(getArg("dnssec-db"), getArg("dnssec-db-journal-mode")));
+    d_dnssecdb = std::make_shared<SSQLite3>(getArg("dnssec-db"), getArg("dnssec-db-journal-mode"));
     setupStatements();
   }
   catch (SSqlException& se) {

diff --git a/modules/ldapbackend/powerldap.cc b/modules/ldapbackend/powerldap.cc
@@ -287,7 +287,7 @@ PowerLDAP::SearchResult::Ptr PowerLDAP::search(const string& base, int scope, co
     throw LDAPException("Starting LDAP search: " + getError(rc));
   }
 
-  return SearchResult::Ptr(new SearchResult(msgid, d_ld));
+  return std::make_unique<SearchResult>(msgid, d_ld);
 }
 
 /**

diff --git a/pdns/dynloader.cc b/pdns/dynloader.cc
@@ -110,7 +110,7 @@ int main(int argc, char **argv)
     string command = commands[0];
     shared_ptr<DynMessenger> D;
     if(::arg()["remote-address"].empty())
-      D=shared_ptr<DynMessenger>(new DynMessenger(socketname));
+      D = std::make_shared<DynMessenger>(socketname);
     else {
       uint16_t port;
       try {
@@ -121,7 +121,7 @@ int main(int argc, char **argv)
         exit(99);
       }
 
-      D=shared_ptr<DynMessenger>(new DynMessenger(ComboAddress(::arg()["remote-address"], port), ::arg()["secret"]));
+      D = std::make_shared<DynMessenger>(ComboAddress(::arg()["remote-address"], port), ::arg()["secret"]);
     }
 
     string message;

diff --git a/pdns/saxfr.cc b/pdns/saxfr.cc
@@ -129,7 +129,7 @@ try
         throw PDNSException("tcp read failed");
 
       len=ntohs(len);
-      std::unique_ptr<char[]> creply(new char[len]);
+      auto creply = std::make_unique<char[]>(len);
       int n=0;
       int numread;
       while(n<len) {
-Original file line number
+Diff line change
@@ Expand Up @@
         throw LDAPException("Starting LDAP search: " + getError(rc));
       }
-      return SearchResult::Ptr(new SearchResult(msgid, d_ld));
+      return std::make_unique<SearchResult>(msgid, d_ld);
     }
     /**
@@ Expand Down @@