dnstap: Fix a missed optimization reported by Coverity

PowerDNS · Jan 19, 2024 · 269e4da · 269e4da
1 parent 66077f9
commit 269e4da
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pdns/dnstap.cc b/pdns/dnstap.cc
@@ -63,7 +63,7 @@ std::string&& DnstapMessage::getBuffer()
 }
 
 DnstapMessage::DnstapMessage(std::string&& buffer, DnstapMessage::MessageType type, const std::string& identity, const ComboAddress* requestor, const ComboAddress* responder, DnstapMessage::ProtocolType protocol, const char* packet, const size_t len, const struct timespec* queryTime, const struct timespec* responseTime, const boost::optional<const DNSName&>& auth) :
-  d_buffer(buffer)
+  d_buffer(std::move(buffer))
 {
   protozero::pbf_writer pbf{d_buffer};