Skip to content

Commit

Permalink
Merge pull request #13787 from omoerbeek/rec-regr-test-skip
Browse files Browse the repository at this point in the history
rec: skip a few tests that depend on sidnlab's public test setup that no longer works
  • Loading branch information
rgacogne authored Feb 13, 2024
2 parents a0c38b8 + 1c47d58 commit 22f5278
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions regression-tests.recursor-dnssec/test_ExtendedErrors.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import dns
import os
import extendederrors
import pytest

from recursortests import RecursorTest

Expand Down Expand Up @@ -82,6 +83,7 @@ def generateRecursorConfig(cls, confdir):

super(ExtendedErrorsRecursorTest, cls).generateRecursorConfig(confdir)

@pytest.mark.skip(reason="sidnlabs no longer serves thiss until further notice")
def testNotIncepted(self):
qname = 'signotincepted.bad-dnssec.wb.sidnlabs.nl.'
query = dns.message.make_query(qname, 'A', want_dnssec=True)
Expand All @@ -95,6 +97,7 @@ def testNotIncepted(self):
self.assertEqual(res.options[0].otype, 15)
self.assertEqual(res.options[0], extendederrors.ExtendedErrorOption(8, b''))

@pytest.mark.skip(reason="sidnlabs no longer serves thiss until further notice")
def testExpired(self):
qname = 'sigexpired.bad-dnssec.wb.sidnlabs.nl.'
query = dns.message.make_query(qname, 'A', want_dnssec=True)
Expand All @@ -121,6 +124,7 @@ def testAllExpired(self):
self.assertEqual(res.options[0].otype, 15)
self.assertEqual(res.options[0], extendederrors.ExtendedErrorOption(6, b''))

@pytest.mark.skip(reason="sidnlabs no longer serves thiss until further notice")
def testBogus(self):
qname = 'bogussig.ok.bad-dnssec.wb.sidnlabs.nl.'
query = dns.message.make_query(qname, 'A', want_dnssec=True)
Expand Down Expand Up @@ -235,6 +239,7 @@ def tearDownClass(cls):
def generateRecursorConfig(cls, confdir):
super(NoExtendedErrorsRecursorTest, cls).generateRecursorConfig(confdir)

@pytest.mark.skip(reason="sidnlabs no longer serves thiss until further notice")
def testNotIncepted(self):
qname = 'signotincepted.bad-dnssec.wb.sidnlabs.nl.'
query = dns.message.make_query(qname, 'A', want_dnssec=True)
Expand Down

0 comments on commit 22f5278

Please sign in to comment.