fix(ux): remove all (min-)h-100vh-scene-header-height, and use flex grow instead #39920
+152
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Size Change: +21 B (0%) Total Size: 3.3 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated12 snapshot changes in total. 0 added, 12 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
adamleithp
force-pushed
the
ux/scenes-flex-grow
branch
from
ff17303 to
d2cd8aa
Compare
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
adamleithp
requested review from
benjackwhite,
pauldambra and
veryayskiy
and removed request for
a team,
benjackwhite,
pauldambra and
veryayskiy
adamleithp
force-pushed
the
ux/scenes-flex-grow
branch
from
21a7902 to
1242051
Compare
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
adamleithp
force-pushed
the
ux/scenes-flex-grow
branch
from
751f078 to
7a8a51a
Compare
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We use some forceful CSS (min-height: 100vh-scene-header-height) to make scenes full viewport height, this isn't ideal as it's cognitive overhead on how to do it
Changes
flexto wrappingscene-layoutallowing...flex-growto take available screen heightSceneContentgets propfullHeightto allow devs to easily reach for good practice.full height persons / group session replays
How did you test this code?
Opened SQL editor, height is full, but scrolls when too short ✅
Opened Replay, height is full, but scrolls when too short ✅
Open Max, height is full, but scrolls when too short ✅